-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore own messages without room_id #282
base: master
Are you sure you want to change the base?
Conversation
I got this backtrace: Traceback (most recent call last): File ".weechat/python/matrix/utf.py", line 89, in wrapper return function(*args, **kwargs) File ".weechat/python/autoload/matrix.py", line 343, in receive_cb server.handle_response(response) File ".weechat/python/matrix/server.py", line 1621, in handle_response self.handle_error_response(response) File ".weechat/python/matrix/server.py", line 1591, in handle_error_response self.handle_own_messages_error(response) File ".weechat/python/matrix/server.py", line 1234, in handle_own_messages_error room_buffer = self.room_buffers[response.room_id] KeyError: '' Not sure if ignoring is the best solution but probably better then throwing an exception.
Any more info about that error, did another traceback happen before whas there some user interaction before that happened? That method is used to print out messages that you sent out, so it's strange that you sent a message in a buffer that doesn't exist. |
I've found the error four times in my logs, every time I've send a message to someone at the same time. Nothing else in the logs around that time. Anything else I should check? |
Actually looking at this, the key that it's using is an empty string, e.g. Python prints out the key in the traceback: >>> x["a"]
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
KeyError: 'a' The room id is passed into the method that is sending out the request and added to the response, it's not part of the server response. Something strange is going on, could you expand on what "at the same time" means? |
Also logs from
|
That almost explains it, but we make sure that the error type takes another path, only a valid |
I got this backtrace:
Traceback (most recent call last):
File ".weechat/python/matrix/utf.py", line 89, in wrapper
return function(*args, **kwargs)
File ".weechat/python/autoload/matrix.py", line 343, in receive_cb
server.handle_response(response)
File ".weechat/python/matrix/server.py", line 1621, in handle_response
self.handle_error_response(response)
File ".weechat/python/matrix/server.py", line 1591, in handle_error_response
self.handle_own_messages_error(response)
File ".weechat/python/matrix/server.py", line 1234, in handle_own_messages_error
room_buffer = self.room_buffers[response.room_id]
KeyError: ''
Not sure if ignoring is the best solution but probably better then
throwing an exception.